search

open-sdg / sdg-build

Python package to convert SDG-related data and metadata between formats
MIT License
5 stars 23 forks source link

Always set all dimensions in SDMX output #217

Closed brockfanning closed 3 years ago

brockfanning commented 3 years ago

In SDMX all of the dimensions are required for each series. So the output here should always set each dimension, regardless of whether there is a value or not. If not, it should always use the default value.

LucyGwilliamAdmin commented 3 years ago

@brockfanning can latest be pulled in from 1.4.0 so I can make use of the updated sdmx library please?

brockfanning commented 3 years ago

@LucyGwilliamAdmin I think it should be there - it's not showing in Github but I've merged the latest code to this branch.

LucyGwilliamAdmin commented 3 years ago

@brockfanning looks good to me:

https://onsdigital.github.io/sdg-sdmx-data/sdmx/3-2-1.xml

brockfanning commented 3 years ago

@LucyGwilliamAdmin Since we're about to push a hotfix release 1.3.1, we have the choice of whether to put this in 1.3.1 or wait for 1.4.0. Thoughts?

LucyGwilliamAdmin commented 3 years ago

@brockfanning I think this is fine to go into 1.3.1 hotfix since it's kind of a bug