Allow column and code mappings to be used

open-sdg / sdg-build

Python package to convert SDG-related data and metadata between formats

MIT License

5 stars 23 forks source link

Allow column and code mappings to be used #236

Closed LucyGwilliamAdmin closed 3 years ago

LucyGwilliamAdmin commented 3 years ago

@brockfanning I think I must have done something wrong as I'm getting this error: https://github.com/ONSdigital/sdg-sdmx-data/runs/2220458700?check_suite_focus=true

I'm not really sure what it means though?

EDIT: Also here's my config: https://github.com/ONSdigital/sdg-sdmx-data/blob/develop/config_data.yml#L57

brockfanning commented 3 years ago

@LucyGwilliamAdmin I think I snuck a bug in with the last PR. I just opened a PR that should fix that: https://github.com/open-sdg/sdg-build/pull/237.

brockfanning commented 3 years ago

@LucyGwilliamAdmin I merged that PR, so I'd recommend merging the latest 1.4.0-dev into this branch.

LucyGwilliamAdmin commented 3 years ago

@brockfanning ok thanks, that fixed the error I was getting - terms are being mapped correctly and SDG Lab is accepting the output - is there anything else that needs to be tested?