Vary by language in some method caches

open-sdg / sdg-build

Python package to convert SDG-related data and metadata between formats

MIT License

6 stars 22 forks source link

Vary by language in some method caches #257

Closed brockfanning closed 3 years ago

brockfanning commented 3 years ago

This fixes a bug where the GeoJSON output doesn't build correctly in the non-default languages. This bug has the effect in Open SDG of preventing maps from working in non-default languages, so this would be an important fix to get in for 1.4.0, I think.

LucyGwilliamAdmin commented 3 years ago

@brockfanning was this bug reported by someone? Just asking before I try to recreate and test fix

brockfanning commented 3 years ago

@LucyGwilliamAdmin No, I only noticed this while trying to set up maps for a multilingual site (Cambodia).

LucyGwilliamAdmin commented 3 years ago

@brockfanning ok, thanks - is this working for them? or should I do separate test?

brockfanning commented 3 years ago

@LucyGwilliamAdmin Yes, it's working well, here's an example with a map: https://sdg-cambodia.github.io/site/2-2-1/