Allow multiple data inputs for the same indicator

open-sdg / sdg-build

Python package to convert SDG-related data and metadata between formats

MIT License

6 stars 22 forks source link

Allow multiple data inputs for the same indicator #294

Closed brockfanning closed 2 years ago

brockfanning commented 2 years ago

@LucyGwilliamAdmin Here is an updated version of this PR. I believe this should get some very critical testing - with both single and multiple data inputs, to ensure there is no unintended consequence.

LucyGwilliamAdmin commented 2 years ago

@brockfanning once #293 has been merged, is it possible for the latest code to be pulled in here so I can use the global SDMX API as an input please?

brockfanning commented 2 years ago

@LucyGwilliamAdmin Yes, that's done.

LucyGwilliamAdmin commented 2 years ago

Testing checklist

[x] 1 source - CSV file: https://uk-sdmx-api-platform.github.io/site/1-1-1/, SDMX API: https://uk-sdmx-api-platform.github.io/site/1-a-2/
[x] 2 sources - different series coming from two sources: https://uk-sdmx-api-platform.github.io/site/1-4-1/
[x] 2 sources - data for same series coming from two sources e.g. different disaggs: https://uk-sdmx-api-platform.github.io/site/1-a-1/

LucyGwilliamAdmin commented 2 years ago

@brockfanning I've added some scenarios that I'm testing above - can you think of any others?