Subclass of geojson output for extra validation with Open SDG

open-sdg / sdg-build

Python package to convert SDG-related data and metadata between formats

MIT License

6 stars 22 forks source link

Subclass of geojson output for extra validation with Open SDG #297

Closed brockfanning closed 2 years ago

brockfanning commented 2 years ago

Q	A
Feature branch/test site URL	Link
Fixed issues	Fixes https://github.com/open-sdg/open-sdg/issues/1566
Related version	2.0.0-dev
Bugfix, feature or docs?	Feature

[ ] Keeps backward-compatibility
[ ] Includes tests
[ ] Updated docs
[ ] Updated config forms
[ ] Added CHANGELOG entry

otis-bath commented 2 years ago

Hi @brockfanning I have pointed towards the branch in sdg-build-1 and removed all the geojson data for 3-3-3 just leaving the column header (this is the combination that caused the issue at first) however the build completed and the spinning wheel is still there http://uk-sdg-feature-branches.s3-website.eu-west-2.amazonaws.com/feature-open-sdg-geojson-abort/3-3-3/ Let me know if there is anything else that needs changing? Thanks

brockfanning commented 2 years ago

@otis-bath Can you try making a pull-request for your branch - as if you were planning to merge it? That is what triggers the validation tests, I believe.