open-sdg / sdg-build

Python package to convert SDG-related data and metadata between formats
MIT License
6 stars 22 forks source link

Rename columns that become duplicates after translation #316

Closed brockfanning closed 2 years ago

brockfanning commented 2 years ago
Q A
Feature branch/test site URL Link
Fixed issues Fixes #315
Related version 2.0.0-dev
Bugfix, feature or docs?
codecov[bot] commented 2 years ago

Codecov Report

Merging #316 (661eb8e) into 2.1.0-dev (b6592d0) will increase coverage by 0.02%. The diff coverage is 81.81%.

@@              Coverage Diff              @@
##           2.1.0-dev     #316      +/-   ##
=============================================
+ Coverage      70.30%   70.32%   +0.02%     
=============================================
  Files             74       74              
  Lines           4532     4536       +4     
=============================================
+ Hits            3186     3190       +4     
  Misses          1346     1346              
Impacted Files Coverage Δ
sdg/Indicator.py 71.98% <81.81%> (+0.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6592d0...661eb8e. Read the comment docs.

LucyGwilliamAdmin commented 2 years ago

I've just added link to description - I think this is what's expected right?

brockfanning commented 2 years ago

@LucyGwilliamAdmin Yes, that seems like what it's coded to do.