open-sdg / sdg-build

Python package to convert SDG-related data and metadata between formats
MIT License
6 stars 22 forks source link

Handle Pandas bug in Series.replace #322

Closed brockfanning closed 1 year ago

brockfanning commented 1 year ago

Fixes #321

Testing instructions: @otis-bath @sarah-beasley The reason that this bug has not been a problem for the UK data builds is that you are using Python 3.7 right now. To see this bug you could update your version of Python to 3.8. To do that in a feature branch you would need to update this line. I believe that if you try that, the build will fail. Then, if you point to this branch in your requirements.txt file, the build should succeed.

So in sum, this bug affects any site using Python 3.8 and also using the code_map parameter in the data config. The UK build is indeed using the code_map parameter in the sdmx_output section.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.40 :tada:

Comparison is base (c78e8bd) 73.76% compared to head (21a0981) 74.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.2.0-dev #322 +/- ## ============================================= + Coverage 73.76% 74.16% +0.40% ============================================= Files 74 74 Lines 4577 4583 +6 ============================================= + Hits 3376 3399 +23 + Misses 1201 1184 -17 ``` | [Impacted Files](https://codecov.io/gh/open-sdg/sdg-build/pull/322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-sdg) | Coverage Δ | | |---|---|---| | [sdg/inputs/InputBase.py](https://codecov.io/gh/open-sdg/sdg-build/pull/322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-sdg#diff-c2RnL2lucHV0cy9JbnB1dEJhc2UucHk=) | `87.05% <100.00%> (+5.43%)` | :arrow_up: | | [sdg/outputs/OutputSdmxMl.py](https://codecov.io/gh/open-sdg/sdg-build/pull/322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-sdg#diff-c2RnL291dHB1dHMvT3V0cHV0U2RteE1sLnB5) | `76.92% <100.00%> (+3.07%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-sdg). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-sdg)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.