open-sdg / sdg-build

Python package to convert SDG-related data and metadata between formats
MIT License
5 stars 23 forks source link

Allow for series in json-stat api inputs #326

Closed brockfanning closed 1 year ago

brockfanning commented 2 years ago
Q A
Feature branch/test site URL [Link](add link here)
Fixed issues Fixes #ISSUENUMBER
Related version 1.5.0-dev
Bugfix, feature or docs?
codecov[bot] commented 2 years ago

Codecov Report

Patch coverage: 13.33% and project coverage change: -0.17% :warning:

Comparison is base (a45a43b) 78.23% compared to head (564b721) 78.07%. Report is 1 commits behind head on 2.3.0-dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.3.0-dev #326 +/- ## ============================================= - Coverage 78.23% 78.07% -0.17% ============================================= Files 74 74 Lines 4618 4629 +11 ============================================= + Hits 3613 3614 +1 - Misses 1005 1015 +10 ``` | [Files Changed](https://app.codecov.io/gh/open-sdg/sdg-build/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-sdg) | Coverage Δ | | |---|---|---| | [sdg/inputs/InputApi.py](https://app.codecov.io/gh/open-sdg/sdg-build/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-sdg#diff-c2RnL2lucHV0cy9JbnB1dEFwaS5weQ==) | `22.53% <7.69%> (-6.50%)` | :arrow_down: | | [sdg/inputs/InputJsonStat.py](https://app.codecov.io/gh/open-sdg/sdg-build/pull/326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-sdg#diff-c2RnL2lucHV0cy9JbnB1dEpzb25TdGF0LnB5) | `38.88% <50.00%> (+1.38%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/open-sdg/sdg-build/pull/326/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-sdg)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sarah-beasley commented 1 year ago

might leave out of 2.2.0 as tests are taking a lot of work to create and not priority as not used by any users.