open-sdg / sdg-build

Python package to convert SDG-related data and metadata between formats
MIT License
6 stars 22 forks source link

Prevent version 5 of frictionless #333

Closed brockfanning closed 1 year ago

brockfanning commented 1 year ago

Frictionless v5 requires Python 3.8, and we have not yet confirmed compatibility with Python 3.8. We can remove this restriction once we're sure that using Python 3.8 is fine.

Q A
Feature branch/test site URL Link
Fixed issues Fixes #ISSUENUMBER
Related version 2.2.0-dev
Bugfix, feature or docs? Bugfix

In theory, with this PR, countries would not need to "pin" the Frictionless package in their requirements.txt file. So this should be tested along with removing that from the requirements.txt file (the line frictionless==4.40.8 could be remove)

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.2.0-dev@9f250e8). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.2.0-dev #333 +/- ## ============================================ Coverage ? 73.76% ============================================ Files ? 74 Lines ? 4577 Branches ? 0 ============================================ Hits ? 3376 Misses ? 1201 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-sdg). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-sdg)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.