Closed LucyGwilliamAdmin closed 5 years ago
@brockfanning: Cambodia POC site also has same issue. We can use add_data_alteration function to replace "Kyrgyzstan" with "".
@LucyGwilliamAdmin I just tried it locally with Cambodia and unfortunately the graph doesn't display now. I'll dig into it a bit more.
@LucyGwilliamAdmin A partial success with Cambodia here.
To see the code that I changed, see here. Some notes:
@brockfanning So I've just tried this here but I'm getting this error: https://travis-ci.org/ONSdigital/sdg-data/builds/597680086
I have just changed git+git://github.com/open-sdg/sdg-build@0.4.1
in requirements.txt to git+git://github.com/open-sdg/sdg-build
and it has built now.
Ok great, this worked. One thing with the fix_data function I used
df['Reference area'] = df['Reference area'].replace('Kyrgyzstan', np.nan)
instead of
df['Reference area'] = df['Reference area'].replace('Kyrgyzstan', '')
as for some reason, the replacing with an empty string wouldn't allow me to select an option from the child disaggregation so just something to be aware of.
Thanks so much for your help.
@LucyGwilliamAdmin Yep, we were figuring out the same thing simultaneously. I just made a commit that should avoid that problem in the future, if someone chooses to use ''
. So that resolves the "edges" issue I mentioned above. I'll go ahead and close this.
For example, here Kyrgyzstan should not be in Reference Area breakdown but should just show as headline data.
Is there something we can do about this?