search

open-services-group / byon

Bring Your Own Notebook (BYON) project repository.
GNU General Public License v3.0
4 stars 8 forks source link

Updated Readme #24

Closed oindrillac closed 2 years ago

oindrillac commented 2 years ago

Related Issues and Dependencies

Added some more context to project readme

This introduces a breaking change

cc: @pacospace

tumido commented 2 years ago

bump @oindrillac do we still want to get this in? Is there any feedback left to address? I'd like to build on top of your PR in here and add a section for dev setup so I'd like to have this merged first :slightly_smiling_face:

oindrillac commented 2 years ago

@tumido yes forgot about this completely. Let me remove some of the specific issues to make this more generic.

oindrillac commented 2 years ago

cc: @tumido can you PTAL?

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacospace, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-services-group/byon/blob/main/OWNERS)~~ [pacospace] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment