search

open-services-group / byon

Bring Your Own Notebook (BYON) project repository.
GNU General Public License v3.0
4 stars 8 forks source link

[1pt] Define new ADR that “bot” is a GitHub App #53

Closed Gkrumbach07 closed 2 years ago

Gkrumbach07 commented 2 years ago

Is your feature request related to a problem? Please describe. Define new ADR that “bot” is a GitHub App

Describe the solution you'd like I want to create an ADR that defines what a bot is in the context of this EPIC. We are using a Github app as a bases of the bot, which will also use probot most likely.

Describe alternatives you've considered Other bot considerations are github actions.

Additional context related: https://github.com/open-services-group/scrum/issues/15

goern commented 2 years ago

I think we have concluded to pivot from a bot-driven use case, to focus on the integration with the odh-dashboard.

is that correct?

if so, can we close this issue?

/kind documentation /priority critical-urgent

Gkrumbach07 commented 2 years ago

/close

sesheta commented 2 years ago

@Gkrumbach07: Closing this issue.

In response to [this](https://github.com/open-services-group/byon/issues/53#issuecomment-1260916696): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.