open-services-group / community

This repository handles a few common things, it is mainly used by our bots...
GNU General Public License v3.0
8 stars 24 forks source link

First draft of device failure prediction WG charter #124

Closed dmick closed 2 years ago

dmick commented 2 years ago

Signed-off-by: Dan Mick dmick@redhat.com

sesheta commented 2 years ago

Hi @dmick. Thanks for your PR.

I'm waiting for a open-services-group member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
erikerlandson commented 2 years ago

cc @MichaelClifford @Shreyanand

erikerlandson commented 2 years ago

/hold

erikerlandson commented 2 years ago

/ok-to-test

MichaelClifford commented 2 years ago

/LGTM

erikerlandson commented 2 years ago

/unhold

erikerlandson commented 2 years ago

@dmick can you change name of the directory to wg-device-failure-prediction? The WG directories all start with wg-

erikerlandson commented 2 years ago

@dmick also we need an entry under the workinggroups section here: https://github.com/open-services-group/community/blob/main/sigs.yaml#L143

erikerlandson commented 2 years ago

@dmick also it looks like I was wrong, we just need to list the orgs in "stakeholders"

erikerlandson commented 2 years ago

/hold

Shreyanand commented 2 years ago

/lgtm

chauhankaranraj commented 2 years ago

/lgtm

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schwesig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-services-group/community/blob/main/OWNERS)~~ [schwesig] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 2 years ago

New changes are detected. LGTM label has been removed.

dmick commented 2 years ago

Updated with Erik's comments, and added github configuration

erikerlandson commented 2 years ago

@Shreyanand can you add @dmick as a org member, to satisfy peribolos?

dmick commented 2 years ago

ping @Shreyanand

Shreyanand commented 2 years ago

/retest

Shreyanand commented 2 years ago

@harshad16 @tumido how can we fix the peribolos test here?

harshad16 commented 2 years ago

as there is a new team creation, the peribolos should be overridden, as it cant do a dry run of the creation of the team. the owner has to done override by using following command:

/override peribolos

sesheta commented 2 years ago

@harshad16: Overrode contexts on behalf of harshad16: peribolos

In response to [this](https://github.com/open-services-group/community/pull/124#issuecomment-1102912648): >as there is a new team creation, the peribolos should be overridden, as it cant do a dry run of the creation of the team. >the owner has to done override by using following command: > >/override peribolos Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Shreyanand commented 2 years ago

/unhold /approve

harshad16 commented 2 years ago

/verify-owners /unhold

dmick commented 2 years ago

The bots have been venerated properly! Hurrah!