open-simh / simh

The Open SIMH simulators package
https://opensimh.org/
Other
473 stars 89 forks source link

macOS-12 CI/CD failure fix, periodic CMake regenerate #398

Closed bscottm closed 3 months ago

bscottm commented 3 months ago
markpizz commented 3 months ago

@bscottm Nice way to slip in your previously discussed and still open cross thread interference changes. See discussion details in that original PR.

bscottm commented 3 months ago

@markpizz: ??? No clue what you're talking about.

markpizz commented 3 months ago

@markpizz: ??? No clue what you're talking about.

Well, I got a email with these contents:

@bscottm pushed 3 commits. • dfb6194 MAKEFILE: Add zlib to macOS deps • 6aa60d8 CMAKE: Regenerate, PDP10 needs USES_AIO • 0998e63 SCP: Fix scp_asynch_check cross-thread interference — View it on GitHub or unsubscribe. You are receiving this because you are subscribed to this thread.

I opened a browser to github.com/open-simh/simh and selected this PR in the Pull Requests and composed my comment.

Ahh, I now see that the subject on the above message was actually due to you had pushing the changes in this PR to your prior PR. Sorry for any confusion.

I'm not sure you should be mixing commits between different PRs though...

bscottm commented 3 months ago

@markpizz: There are only two commits here, both related to the build system (makefile and CMake). There's nothing from my scp-async-check branch. You may have seen activity on my other branches when I updated my repo to sync with open-simh/master on several branches.

deltecent commented 3 months ago

Nice work.