search

open-simulation-platform / cosim-cli

Command-line interface for libcosim
https://open-simulation-platform.github.io/cosim
Mozilla Public License 2.0
10 stars 4 forks source link

Revert "Custom find modules no longer necessary" #24

Closed kyllingstad closed 5 years ago

kyllingstad commented 5 years ago

Reverts open-simulation-platform/cse-cli#20. It broke the Linux build.

markaren commented 5 years ago

The error:

Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 

CMake Error at /usr/local/lib/python3.6/dist-packages/cmake/data/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:137 (message):

  Could NOT find GSL (missing: GSL_INCLUDE_DIR GSL_LIBRARY GSL_CBLAS_LIBRARY)

  (found version "")

Call Stack (most recent call first):

  /usr/local/lib/python3.6/dist-packages/cmake/data/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)

  /usr/local/lib/python3.6/dist-packages/cmake/data/share/cmake-3.13/Modules/FindGSL.cmake:148 (find_package_handle_standard_args)

  /usr/local/lib/python3.6/dist-packages/cmake/data/share/cmake-3.13/Modules/CMakeFindDependencyMacro.cmake:48 (find_package)

  /conan_repo/.conan/data/cse-core/0.4.0/osp/master/package/75791290e778569bd3c466c3feb0a2b7870969e6/share/csecore/cmake/csecore-config.cmake:32 (find_dependency)

  CMakeLists.txt:31 (find_package)
markaren commented 5 years ago

Easier to just add PkgConfig ?

hplatou commented 5 years ago

Unfortunately, that does not help. Tried locally.

markaren commented 5 years ago

What error do you get? This would be an issue not just for cse-cli so would be nice to resolve it.

hplatou commented 5 years ago

Just the same, except it finds PkgConfig.

markaren commented 5 years ago

Ok, the source of the error is that our FindGSL shadows ubuntus FindGSL (two different libs). So the bug is in cse-core. FindGSL should be renamed.