search

open-simulation-platform / libcosim

OSP C++ co-simulation library
https://open-simulation-platform.github.io/libcosim
Mozilla Public License 2.0
61 stars 10 forks source link

Expose only model description through execution #603

Closed eidekrist closed 4 years ago

eidekrist commented 4 years ago

This closes #602.

execution.get_simulator() has been replaced with execution.get_model_description(). If this gets approved, I will create separate PR's for libcosimc and cosim4j updating the usage of the replaced method.

I also did a change in observer.hpp, returning const references for the name() and model_description() methods. Please let me know if that was a bad call!

markaren commented 4 years ago

Change looks fine to me. I double checked cosim4j, and the get_simulator call is only used as you say to get the model_description.

I will create separate PR's for libcosimc and cosim4j updating the usage of the replaced method.

No need (for cosim4j). I can do it, as the natives should be built and checked in for both windows and linux.