Current do-loop implementation of simulate_until() allows single steps to be taken after end time is exceeded if the optional end time is provided. It would probably be more intuitive that the simulation will only step if the end time is not exceeded. The step function can be used if a single simulation step is the intended behavior.
Furthermore, the stopped_ flag is not reset if the simulate_until() function is ended by timeout. is_running() is determined by the inverse of the stopped_ flag. The simulation then ends up in a state where it is effectively paused as it is no longer stepping while the indicated state accessed by is_running() will return true. is_running() is documented as "Is the simulation loop currently running" which it will not be if the simulate_until() while loop is ended by time_out() returning true. stop_simulation() is documented as "Stops the co-simulation temporarily" which should probably be called after the simulate_until() function has successfully completed all steps. stop_simulation() sets the stopped_ flag to true.
Current do-loop implementation of
simulate_until()allows single steps to be taken after end time is exceeded if the optional end time is provided. It would probably be more intuitive that the simulation will only step if the end time is not exceeded. The step function can be used if a single simulation step is the intended behavior.Furthermore, the
stopped_flag is not reset if thesimulate_until()function is ended by timeout.is_running()is determined by the inverse of thestopped_flag. The simulation then ends up in a state where it is effectively paused as it is no longer stepping while the indicated state accessed byis_running()will return true.is_running()is documented as "Is the simulation loop currently running" which it will not be if thesimulate_until()while loop is ended bytime_out()returning true.stop_simulation()is documented as "Stops the co-simulation temporarily" which should probably be called after thesimulate_until()function has successfully completed all steps.stop_simulation()sets thestopped_flag to true.