search

open-simulation-platform / libcosim

OSP C++ co-simulation library
https://open-simulation-platform.github.io/libcosim
Mozilla Public License 2.0
54 stars 10 forks source link

Preparing for 0.10.0 release #726

Closed restenb closed 1 year ago

restenb commented 1 year ago

Seems we are now ready to release!

Please review the changelog updates. I'll proceed with the release once this is approved.

One question about release: in order to push a tagged artifact to JFrog, the easiest way is to tag manually with Git as 0.10.0, and push it? From reading the GitHub Action scripts, that seems to be what's going on. 

VERSION="v$(<version.txt)"
if [[ $GITHUB_REF == refs/tags/* ]] && [[ $REFNAME == $VERSION ]]; then CHANNEL="stable"

So if I have it right it'll go something like this; merge this, tag master as 0.10.0, force push version.txt with 0.10.0 to master, and new 0.10.0 release artifacts should be built and uploaded to stable channel? Please do correct me if I'm wrong ... :)

markaren commented 1 year ago

libcosim is automatically uploaded to stable when making a GitHub release (which tags it). Why would you consider force pushing? Some PR would increase the version number prior to releasing (probably this one).

restenb commented 1 year ago

I didn't see version.txt being updated in the pull for the last release, so I assumed it was force pushed to master at some point?

This means all I need to do is merge this, and then release from the GitHub GUI via releases->draft new release?

Edit; I'm just confusing myself :) - version.txt is currently correct at 0.10.0 of course. It just needs to be updated after the release. That might have just been done with a force push to master last time I guess.

markaren commented 1 year ago

Yes, merge this then make a GitHub release with a tag matching the current version. Conan is then automatically triggered.

Updating the version after the fact has been done with both trivial PRs and direct pushes to master. I see that the latter has been most used. So just a regular push to master (no force push) would suffice I guess.

Example of previsous version bump PR: https://github.com/open-simulation-platform/libcosim/pull/567