open-simulation-platform / libcosim

OSP C++ co-simulation library
https://open-simulation-platform.github.io/libcosim
Mozilla Public License 2.0
61 stars 10 forks source link

Upgrade to Conan 2 #747

Closed kyllingstad closed 9 months ago

kyllingstad commented 1 year ago

This fixes issue #718, “Conan v2 compatibility”. (Note that it also destroys Conan 1.x compatibility – it was simply too difficult to maintain support for both major versions.)

Some collateral changes warrant further explanation:

The pull request depends on open-simulation-platform/proxy-fmu#92, which should be merged first. Then, the osp/testing-… channel should be replaced in the proxyfmu requirement specification in conanfile.py before merging the present PR.

Incidentally, this PR also fixes issue #702.

kyllingstad commented 1 year ago

Seems like this PR closes several build-related issues. I linked them now.

davidhjp01 commented 9 months ago

@kyllingstad @restenb

Edit It is because there are no gcc-9 builds available in conancenter

davidhjp01 commented 9 months ago

I have addressed the most of the issues related to the failing builds. I suggest to merge and release libcosim and proxyfmu so that other projects dependent on conan2 library can consume them.

kyllingstad commented 9 months ago

@davidhjp01, sorry for dropping the ball on this at the end of last year, and huge thanks to you for picking it up! It's really good to finally get this merged.

kyllingstad commented 9 months ago

Following up on your question (too late for this PR, unfortunately):

Wondering if we should remove Debug builds because it seems the case for the most of the libraries in conan2 public repository (to avoid lengthy github action builds).

Yes, I think that sounds like a good idea. I don't think I can remember a case where the release builds succeeded while the debug builds failed or vice versa.