search

open-simulation-platform / libcosimc

OSP C co-simulation API
Mozilla Public License 2.0
12 stars 2 forks source link

Update after libcosim release #39

Closed restenb closed 1 year ago

restenb commented 1 year ago

Updating to 0.10.0/stable after libcosim release. Or should we go to 0.11.0/testing?

Also removed GCC 7&8 from the build matrix here as well - shout if you disagree :)

@markaren the builds with proxyfmu=ON are all failing on GCC9 with the same error message - any ideas?

CMake Error at C:/Program Files/CMake/share/cmake-3.25/Modules/CMakeFindDependencyMacro.cmake:47 (find_package): By not providing "FindThrift.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "Thrift", but -- Configuring incomplete, errors occurred! See also "C:/.conan/f67648/1/CMakeFiles/CMakeOutput.log". CMake did not find one. See also "C:/.conan/f67648/1/CMakeFiles/CMakeError.log".

Could not find a package configuration file provided by "Thrift" with any of the following names:

ThriftConfig.cmake
thrift-config.cmake

Add the installation prefix of "Thrift" to CMAKE_PREFIX_PATH or set "Thrift_DIR" to a directory containing one of the above files. If "Thrift" provides a separate development package or SDK, be sure it has been installed.

markaren commented 1 year ago

About Thrift: The generator needs to be updated to cmake_find_package. Will check later this evening.

markaren commented 1 year ago

Yeah.. I'm not sure. I made it work locally, but the CI uses conan create and got a different result. Ideally, the conan packages across the organization should be rewritten as they are out of date with the current best practices etc. The problem is that the environment is changing so fast and the changes required are big.

We could go back to proxy-fmu and revert the cmake_find_package change, but.......

markaren commented 1 year ago

See #40, but here we use conan's own findlibcosim. Could have side-effects (?)..