open-simulation-platform / osp-validator

Ontology-based systems structure validator
Mozilla Public License 2.0
4 stars 1 forks source link

feature/refactoring #2

Closed mrindar closed 5 years ago

mrindar commented 5 years ago

Complete rewrite, so good luck reviewing. You can pull the branch down and run the main method inside the main.Main class. This will generate configuration.owl in the project directory which you can open in Protege and run the Hermit reasoner on. Currently there is an issue with the bonds not being classified as specific bond types, but will open separate issue on this.

mrindar commented 5 years ago

we are now using the osp.owl file for getting the prefixes right?

Correct. We use the osp.owl file to get all the class definitions and object properties which we use to describe the content of the cse-config.json file. Right now we do this because it is easier to develop and maintain the osp ontology through protege, but further down the line we might implement the whole thing in java using the owlapi instead of going via protege.

The latest version of HermiT supports OWL API 3.4.3, and we are using 3.5.1. Will that be a problem? I'm guessing that at some stage we will include the HermiT jar and do reasoning directly?

I thought I had updated it! Luckily it didn't require much changes. Nice catch 👍