search

open-simulation-platform / osp-validator

Ontology-based systems structure validator
Mozilla Public License 2.0
4 stars 1 forks source link

Changed fmuproxy to fmu-proxy #75

Closed THEvang closed 4 years ago

THEvang commented 4 years ago

Replaces fmuproxy with fmu-proxy

closes #74

mrindar commented 4 years ago

Does libcosim expect the schema to be fmu-proxy instead of fmuproxy now?

THEvang commented 4 years ago

I think so. See issue #74 for more info.

There is also a problem with finding FMU proxy FMU's by GUID (issue #76)

mrindar commented 4 years ago

HOORAY for moving targets! :) This is a critiacl bug that should be hotfixed into master. See here under Hotfix Branches.

mrindar commented 4 years ago

There is also a problem with finding FMU proxy FMU's by GUID (issue #76)

I was not made aware that guid was a possible schema. I wouldn't say that it is a critical bug though, because we explicitly state that we only support fmuproxy and file uri schemas. Perhaps you could make an issue stating that we should add support for guid uri schemas as well?

THEvang commented 4 years ago

HOORAY for moving targets! :) This is a critiacl bug that should be hotfixed into master. See here under Hotfix Branches.

Is it ok if I merge this branch directly to master?

According to the gitflow workflow hotfix branches should come from master.

THEvang commented 4 years ago

I'll do it the proper way instead of being lazy

mrindar commented 4 years ago

HOORAY for moving targets! :) This is a critiacl bug that should be hotfixed into master. See here under Hotfix Branches.

Is it ok if I merge this branch directly to master?

According to the gitflow workflow hotfix branches should come from master.

I think it is easiest to just create the hotfix branch from master, and cherry pick this commit. Then edit this PR to merge hotfix branch back into master. After that I'll create new release binaries