Should validator support identifying FMUs by GUID?

open-simulation-platform / osp-validator

Ontology-based systems structure validator

Mozilla Public License 2.0

4 stars 1 forks source link

Should validator support identifying FMUs by GUID? #76

Open THEvang opened 4 years ago

THEvang commented 4 years ago

OSP Validator cannot locate FMUs when the source is specified as an GUID, and using FMU proxy. For instance, <Simulator name="vessel_model" source="fmu-proxy://localhost:9090?guid=b71f76f7-b51e-40d5-affb-f63905622e2b" stepSize="0.05"/> resolves to _OspModelDescription.xml when locating the FMUs OSP-IS file.

I am wondering whether this should be supported by OSP-IS or not.

markaren commented 4 years ago

I think the only way of properly handling this would be to expand the RPC API of fmu-proxy to allow retrieval of files within the FMU. Remember that the FMU served by fmu-proxy does not necessarily reside on the same computer as the simulation. libcosim could then use this to save the XML somewhere to be read. This would assume the config file resides inside the FMU.

markaren commented 4 years ago

I'm in progress of re-writing fmu-proxy so that servers are automatically spawned for new FMU instances. With this scheme, loading by GUID will no longer be needed (or possible). As long as localhost is used, the fmu file will not be sent over the wire. That should resolve this issue. Can't say if/when this feature will be integrated into libcosim though.