open-source-firmware / go-tcg-storage

Go library for interfacing TCG Storage functions on storage devices
BSD 3-Clause "New" or "Revised" License
21 stars 10 forks source link

INC_512 usage #96

Open baloo opened 2 years ago

baloo commented 2 years ago

Hi maintainers! Just a heads up regarding the comment about INC_512 here: https://github.com/open-source-firmware/go-tcg-storage/blob/42a62258121f4cb1b4093e480b8d4cf001b7cade/pkg/drive/sgio/ops.go#L294

I believe that seagate is correct in requiring the bit to be set (this is also required on a western digital drive I'm using). But the INC_512 bit is expected to be set to zero in some conditions as pointed in this spec. https://www.trustedcomputinggroup.org/wp-content/uploads/TCG_SWG_SIIS_Version_1_03_Revision_1_00.pdf#page=14

SCSI spec about the SECURITY_PROTOCOL_IN command: https://www.seagate.com/files/staticfiles/support/docs/manual/Interface%20manuals/100293068j.pdf#G4.1733978