Closed austinandrews closed 1 year ago
Hey Austin,
Thank you for checking out our application and reaching out. We appreciate it!
Git/GitHub Workflow
master
branch as I would like to ensure that this configuration was not done intentionally. I agree that all PRs should be made to the develop
branch to ensure functionality.Process Logs
Testing Check & CI/CD
Thank you so much for your contribution and advice on our release. Please resubmit the PR to the develop
branch when time permits and I will happily approve it.
Overview
master
is marked as the default branch so making a PR to that branch, but would probably be better to protect it and do periodic releases from thedevelop
ordevelopment
branch.Anyways, was giving the new app a spin (cool stuff) and was having trouble getting the process logs to load. Looked at the console and err was undefined on line 308 of
commands.tsx
. So I fixed that and now the process logs seem to be working.Testing If I recall correctly this repo has a Travis check that runs tests so we will see (Jest failed when I tried to run them locally against a locally running version of the app).
Further discussion I'm not sure who the most recent maintainers are, I just tagged the reviewer that GH suggested to me. Feel encouraged to weigh in even if you haven't been tagged.