search

open-source-labs / Docketeer

A Docker & Kubernetes developer tool to manage containers & visualize both cluster and container metrics
https://docketeer.io/
MIT License
863 stars 235 forks source link

Use a different port than 8080 #170

Open ScottChapman opened 1 year ago

ScottChapman commented 1 year ago

Is your feature request related to a problem? Please describe. 8080 is already used by many things...

Describe the solution you'd like It would be nice to provide a mechanism to specify what port to use, and maybe default to one less common

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

MikeRavenelle commented 1 year ago

I will second this request. Having a way to configure the port to something other than 8080 is a must.

andrewnicols commented 1 year ago

I'm going to have to disable Docketeer until this is possible, so another +1 here.

MikeRavenelle commented 1 year ago

It looks like we can just modify a few files and it should work. I am going to create a fork with a different port than 8080. Which port do you guys think would be best? 5893 seems like a good used port. If I understand correctly, this port is just used internally within docketeer?

ScottChapman commented 1 year ago

Yea, I think pick something unusual. Would be nice to be able to set an env var (or something) to be able to set it to something if that is also used.

I think the problem is that not that it is used internally, but that it listens on that port externally.

MikeRavenelle commented 1 year ago

I went with 5893 for now. I agree with making it modifiable within the compose file being the best solution via a variable.

It seems to work but unfortunately due to another sign up bug I can not login and test. I even tried making the change with version XII (which is what my code is currently based off of).

Edit: I also made some changes to have a .env file with the port configurable. It also seems to work, but unable to fully test without being able to log in.