Pre Launch Final Bug Squashing Pt 1

[kevinfey]

Types of changes

• [x] Bugfix (change which fixes an issue)
• [ ] New feature (change which adds functionality)
• [ ] Refactor (change which changes the codebase without affecting its external behavior)
• [ ] Non-breaking change (fix or feature –that would causes existing functionality to work as expected)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

Address black screen of death on History tab within React Router apps Fix styling error in AtomsRelationship.tsx Clean up code in StateRoutes Clean up code in PerfView

Approach

Change line 111 in History.tsx. Now avoids a crash caused by moving to a route with no children.

        if (d.data.stateSnapshot.children[0].componentData.actualDuration){
          loadTime = d.data.stateSnapshot.children[0].componentData.actualDuration;
        } else{
          loadTime = 1;
        }

Set height of Sankey chart to 98% to allow space for buttons and fix layout bug.

Learning

Testing a broader range of apps exposed new bugs in code.

[haejinjo]

This PR was closed because it was made to the wrong repository!