search

open-source-labs / Reactime

Developer tool for time travel debugging and performance monitoring in React applications.
https://www.reacti.me
MIT License
2.17k stars 200 forks source link

Uncaught RangeError: Maximum call stack size exceeded in backend.bundle.js #250

Closed kerenren closed 1 year ago

kerenren commented 3 years ago

Hi recently I got this error when I open my react app in development mode: image

It seems this function S has been called in an infinity loop image

Perfomace record: image

More details:

React v17.0.2 Redux v4.0.4 redux-thunk v2.3.0 React-Redux v7.1.0

germanurrus commented 3 years ago

Got the same issue using Next.js, I just disabled the extension and it's working now....lost a lot of time trying to figure it out :(

kerenren commented 3 years ago

Got the same issue using Next.js, I just disabled the extension and it's working now....lost a lot of time trying to figure it out :(

To get rid of the errors and be able to access react dev tool, I have to remove react time extension as well, though react time is a nice extension. Hope this issue could be fixed.

Elyx0 commented 2 years ago

Same problem. Reactime 11.0.0

React Developer Tools 4.21.0 (10/31/2021)

Gatsby 3.14

Screen Shot 2021-11-30 at 12 41 24 AM
mapsgeek commented 2 years ago

same on Nextjs setup

aspiers commented 2 years ago

I have proposed a fix for this in #257. It seems to work fine for me. Would be great if others could test it and report back here. If you don't know how, please see #255 (and also #253, #254).

deadcoder0904 commented 2 years ago

same error made me lost a lot of time. i thought something was wrong with my code but it was the extension. plz fix it. i'll disable it until then :)

fahad-attech commented 2 years ago

same error made me lost a lot of time. i thought something was wrong with my code but it was the extension. plz fix it. i'll disable it until then :)

Same

kbzowski commented 2 years ago

Can confirm too. Uninstalling extension fix the error.

aspiers commented 2 years ago

Or you could try the fix I proposed above ;-)

tyfiero commented 2 years ago

This error is still happening for me, makes the extension unusable, unfortunately. I'm using Next.js 12.2 and React 18. If @aspiers has a fix, why not implement it?

jemzir commented 1 year ago

Implemented a depth limiter that should now fix this issue in v17.0.0!

aspiers commented 1 year ago

@jemzir I submitted a depth limiter fix in 2021 (see #257 as mentioned above) but it seems like no one reviewed it yet. It would be really nice if all the fixes I submitted a long time ago could be reviewed - perhaps then you could save time having to duplicate the same fixes yourself. There are 5 PRs I submitted which are still open. Thanks for your consideration!

benmarg commented 1 year ago

Hi @aspiers, we did actually implement that fix in this release! You're contributions were incredibly clutch, sorry it took the team so long get around to implementing them! We're going to be closing the corresponding PRs to the solutions we managed to implement this release shortly. Thanks again so much!

aspiers commented 1 year ago

Glad to hear you've found them useful :-) But I'm a bit puzzled why there was any need to reimplement this fix I submitted instead of just merging it? I submitted the fix in #257 on Dec 11 2021, and I see that the exact same code change was committed a year later in fdb65c58e, without my name or email as the git committer, and without the explanation I took the time to write in my commit message. Meanwhile #257 has gone over two years without any feedback at all.

Apologies if this sounds a bit petty, especially since I know this is a tiny code change - but it's the principle behind it which I want to highlight. TBH it's a bit demoralising when I go to the effort of implementing a fix and even documenting it nicely, and then it gets reimplemented without any trace in the git history of my contribution. In that kind of scenario, there's no evidence that I saved anyone else's time, or that I didn't waste my own. Please don't get me wrong - I'm quite sure there was zero ill intentions here! And also I know how hard it is to find spare time to maintain F/OSS projects; I do it myself, and sometimes I don't do a great job, so I can't even claim to fully practice what I preach.

But if you want to keep encouraging contributions from the wider community, as much as possible I'd recommend trying to give contributors the satisfaction of seeing our commits merged into the git history. I don't ask for anything else, but that feeling of having proof I contributed is a little feel-good kick which motivates me to do it in the first place, and I'm pretty sure a lot of other F/OSS contributors feel the same :-)

Hope that makes sense, and thanks for listening!