search

open-source-parsers / jsoncpp

A C++ library for interacting with JSON.
Other
8.06k stars 2.63k forks source link

Update CMake minimum to 3.16.3 #1517

Closed juan-lunarg closed 9 months ago

juan-lunarg commented 9 months ago

Fixes warnings from using find_package(jsoncpp CONFIG) and simplifies the code

juan-lunarg commented 9 months ago

Fixes warnings from using find_package(jsoncpp CONFIG) and simplifies the code

To be clear this is the warning I'm talking about:

CMake Deprecation Warning at external/Debug/64/jsoncpp/build/install/lib/cmake/jsoncpp/jsoncppConfig.cmake:2 (cmake_policy):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
Call Stack (most recent call first):
  via/CMakeLists.txt:69 (find_package)

I've tested the changes I've made in this PR against LunarG/VulkanTools and verified it works.