open-southeners / vscode-laravel-pint

🍺 Integrates Laravel Pint into your VSCode projects for automatic code formatting
https://marketplace.visualstudio.com/items?itemName=open-southeners.laravel-pint
MIT License
80 stars 17 forks source link

chore(schema): change referenced schema to the schema in the extension #13

Closed yaegassy closed 2 years ago

yaegassy commented 2 years ago

Description

Currently, it references a GitHub repository.

Inclusion in the extension itself allows pint.json autocompletion and validation to work without network access.

Before

"jsonValidation": [
    {
        "fileMatch": "pint.json",
        "url": "https://raw.githubusercontent.com/open-southeners/vscode-laravel-pint/main/pint-schema.json"
    }
],

After

"jsonValidation": [
    {
        "fileMatch": "pint.json",
        "url": "./pint-schema.json"
    }
],

Note

If you are intentionally referencing a GitHub repository, please close this pull request. 🙇

d8vjork commented 2 years ago

Yeah, I see this as a possible complaint for companies that restrict their network traffic or uses firewalls

The only problem is that the extension itself need to be updated every time PHP CS Fixer does, that was the reason why

I'll leave this open until someone complains about this

yaegassy commented 2 years ago

Thanks for the reply. I am closing this pull request. If changes are needed, please make adjustments in your commit at that time. 🙇