Closed apaletta3 closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.86%. Comparing base (
fd49513
) to head (886607d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Users can create a
CoordinateSubset
, giving it a specific name and number of coordinates in the subset. However, if they use theinFrame
conversion method on theCoordinateSubset
class itself, it doesn't actually do the conversion they want, it just returns the coordinates as they are.This is fine for scalar subsets, but not fine for vector coordinate subsets because it is a hidden behavior the user may not be aware of. Therefore, if someone tries to do this, I will raise an error.
If the user wants to make their own non-scalar coordinate subset by inheriting from
CoordinateSubset
, then they can get around this error by acutally implementing thevirtual
inFrame
method and overriding it in their child class.