search

open-space-collective / open-space-toolkit-physics

Physical units, time, reference frames, environment modeling.
https://open-space-collective.github.io/open-space-toolkit-physics/
Apache License 2.0
25 stars 7 forks source link

feat!: remove duration constructor for python, use static methods #249

Closed vishwa2710 closed 6 months ago

vishwa2710 commented 6 months ago

Amit was burned by this as he didn't realize he was instantiating a Duration with nanoseconds. IMO we should just used the named constructors as it's safest.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.70%. Comparing base (10d14ca) to head (4cc63a6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #249 +/- ## ======================================= Coverage 80.70% 80.70% ======================================= Files 97 97 Lines 7599 7599 ======================================= Hits 6133 6133 Misses 1466 1466 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.