search

open-space-collective / open-space-toolkit-physics

Physical units, time, reference frames, environment modeling.
https://open-space-collective.github.io/open-space-toolkit-physics/
Apache License 2.0
25 stars 7 forks source link

refactor: loosen datetime conversion limit to 2554 (from 2030) #260

Closed kyle-cochran closed 3 months ago

kyle-cochran commented 3 months ago

The hypothesis about this limit is that we want to avoid overflow of the Uint64 nanosecond count value that is stored. The number of years we can store is roughly 584.8, so this sets the limit to 584 years in the future.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.24%. Comparing base (45c2fd7) to head (557fb94).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #260 +/- ## ======================================= Coverage 81.24% 81.24% ======================================= Files 97 97 Lines 7982 7982 ======================================= Hits 6485 6485 Misses 1497 1497 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.