open-space-collective / open-space-toolkit

Collection of versatile software libraries for space engineering applications.
Apache License 2.0
170 stars 7 forks source link

feat: enable CI to build base image for arm64 and amd64 #96

Closed guillaumeloftorbital closed 6 months ago

guillaumeloftorbital commented 7 months ago

Description

Testing

Derollez commented 7 months ago

@guillaumeloftorbital How long does it take using the cache in the CI? Also were you able to confirm that it is able to use the cache from one build to another? 🤔 Looks great man, thanks for the awesome addition

guillaumeloftorbital commented 7 months ago

@Derollez the CI takes ~6h but with cache is faster this job only take 1min for example https://github.com/open-space-collective/open-space-toolkit/actions/runs/8038419090

guillaumeloftorbital commented 7 months ago

e branch as well so that we only run the arm package building for both cpp and python on main instead of on every pull request? Because the arm package building lengthens the pipeline, and we just put effort into reducing its length recently

my issue with disabling the build for arm64 is that it could be easy to break the build but we will only see on release

apaletta3 commented 7 months ago

e branch as well so that we only run the arm package building for both cpp and python on main instead of on every pull request? Because the arm package building lengthens the pipeline, and we just put effort into reducing its length recently

my issue with disabling the build for arm64 is that it could be easy to break the build but we will only see on release

@guillaumeloftorbital No, I don't mean only on release, I mean only on main and also on release. So if it breaks on main after we merge we'll see it right away and not have to wait for a release. We already do this in ostk-astro with validation tests (kind of like integration tests) that only run on main to keep the length of the CI down.

So could you make this change please?