search

open-spaced-repetition / fsrs-rs

FSRS for Rust, including Optimizer and Scheduler
https://crates.io/crates/fsrs
BSD 3-Clause "New" or "Revised" License
160 stars 18 forks source link

warning in compile #41

Closed asukaminato0721 closed 1 year ago

asukaminato0721 commented 1 year ago

just a note for someone interests.

warning: the following packages contain code that will be rejected by a future version of Rust: nom v1.2.4
❯ cargo tree -i nom@1.2.4
nom v1.2.4
└── meval v0.2.0
    └── textplots v0.8.0
        └── burn-train v0.9.0 (https://github.com/burn-rs/burn.git?rev=a4a9844da3c906e3d4795a6c72ae8c099b7187bb#a4a9844d)
            ├── burn v0.9.0 (https://github.com/burn-rs/burn.git?rev=a4a9844da3c906e3d4795a6c72ae8c099b7187bb#a4a9844d)
            │   └── fsrs-optimizer-rs v0.1.0 (/home/w/gitproject/fsrs-optimizer-burn)
            └── fsrs-optimizer-rs v0.1.0 (/home/w/gitproject/fsrs-optimizer-burn)

https://github.com/rekka/meval-rs/pull/27

not a big deal though.

dae commented 1 year ago

The text plotting library is using a number of old dependencies, and I might submit a PR to burn in the future to make it optional.

asukaminato0721 commented 1 year ago

https://github.com/open-spaced-repetition/fsrs-rs/security/dependabot/2

cargo tree -i atty

atty v0.2.14
└── clap v2.34.0
    └── structopt v0.3.26
        └── textplots v0.8.2
            └── burn-train v0.10.0 (https://github.com/burn-rs/burn.git?rev=dbc5f0a340136251170138f8825062b42ed2d096#dbc5f0a3)
                └── burn v0.10.0 (https://github.com/burn-rs/burn.git?rev=dbc5f0a340136251170138f8825062b42ed2d096#dbc5f0a3)
                    └── fsrs v0.1.0 (/home/w/gitproject/fsrs-rs)
                    [dev-dependencies]
                    └── fsrs v0.1.0 (/home/w/gitproject/fsrs-rs)

yet another warning, just put it here for reference.

dae commented 1 year ago

Should be fixed once https://github.com/burn-rs/burn/pull/790 lands