search

open-spaced-repetition / fsrs4anki-helper

An Anki add-on that supports Postpone & Advance & Load Balance & Easy Days & Disperse Siblings & Flatten
https://ankiweb.net/shared/info/759844606
MIT License
215 stars 18 forks source link

Update query for cards to reschedule in sync hook #420

Closed user1823 closed 5 months ago

user1823 commented 5 months ago

Fix: Don't exclude cards done in filtered deck with rescheduling enabled

user1823 commented 5 months ago

A scope for improvement:

If auto_disperse_after_reschedule is enabled, don't exclude Manual entries (i.e., remove the condition ease > 0).

This will allow the add-on to disperse siblings after the user optimizes the parameters and uses "Reschedule cards on change" on another device.

L-M-Sherlock commented 5 months ago

Have you tested it several times?

user1823 commented 5 months ago

I have tested it a few times. If you want, you can wait for 1-2 days so that I get to test it more.

To clarify, I am talking about the changes already made in this PR. I don't know how to implement the change I proposed in my comment (https://github.com/open-spaced-repetition/fsrs4anki-helper/pull/420#issuecomment-2156035272).

L-M-Sherlock commented 5 months ago

I have tested it a few times. If you want, you can wait for 1-2 days so that I get to test it more.

It would be better if you can test it more.

I don't know how to implement the change

See my last commit 150b73f. Could you help me test it?

user1823 commented 5 months ago

See my last commit. Could you help me test it?

Seems to be working well.

user1823 commented 5 months ago

I have tested it multiple times and it seems to be working well.