open-spaced-repetition / fsrs4anki-helper

An Anki add-on that supports Postpone & Advance & Load Balance & Easy Days & Disperse Siblings & Flatten
https://ankiweb.net/shared/info/759844606
MIT License
215 stars 18 forks source link

Refactor/load balance & easy days #461

Closed L-M-Sherlock closed 2 months ago

L-M-Sherlock commented 2 months ago

The load balance and easy days features are refactored in the way discussed in:

Patch: fsrs4anki-helper.ankiaddon.zip

Preview:

image image
Expertium commented 2 months ago

I don't see why you are doing this in the first place. If Easy Days and Load Balance will work the same way both natively and in the add-on, what reason would there be to keep both? If one offers different pros and cons, sure. But if the add-on versions and the native versions are the same, why keep duplicate functionality?

L-M-Sherlock commented 2 months ago

Firstly, I don't know when the Easy Days will be implemented natively. Secondly, implementing it in the add-on could help us test the method easily. Finally, someone ask for this feature, and I'd like to check the method.

L-M-Sherlock commented 2 months ago

By the way, it really helped me improve the method of easy days.

Before https://github.com/open-spaced-repetition/fsrs4anki-helper/pull/461/commits/43a61aa4e747bc39df9a107c1065ec25a285579e:

image

After https://github.com/open-spaced-repetition/fsrs4anki-helper/pull/461/commits/43a61aa4e747bc39df9a107c1065ec25a285579e:

image

It is closer to 50% (reduce mode) than previous one.

brishtibheja commented 2 months ago

@expertium a lot of users don't update and intentionally/unintentionally keep themselves on old versions. So it might be useful for them.

edit: "set the review ratio for each day of the week" should be "set the review amount..." ratio is weird now.

Expertium commented 2 months ago

I would replace "Reduce" with "Reduced" and "Minimize" with "Minimum".