search

open-spaced-repetition / py-fsrs

Python Package for FSRS
https://pypi.org/project/fsrs/
MIT License
145 stars 23 forks source link

Lapse count of cards #17

Closed l3kn closed 1 year ago

l3kn commented 1 year ago

In the update_state function at https://github.com/open-spaced-repetition/py-fsrs/blob/main/src/fsrs/models.py#L87 the lapse count of a card is only incremented for cards in the new and review state.

Is this a bug or the intended behavior? Anki seems to increment the lapse count only for review card.

While this is not relevant for the core logic of the algorithm, I'm trying to reimplement FSRS in EmacsLisp and I'd like to understand the motivation behind this behavior.

L-M-Sherlock commented 1 year ago

It is a bug. I will fix it soon.