open-spaced-repetition / rs-fsrs

Rust-based Scheduler for FSRS
https://crates.io/crates/rs-fsrs
MIT License
24 stars 6 forks source link

Hard and Easy scheduling fix #7

Closed GraesonB closed 1 year ago

GraesonB commented 1 year ago

Some more oversights on my part. I suppose we might want to updated the tests to test against a more diverse set of ratings and instances.

I've been reviewing cards daily with these fixes and I think these are the last of the bugs. Seems to be functioning as expected now. I also changed the code that ensures hard < good < easy to use std::cmp

asukaminato0721 commented 1 year ago

@L-M-Sherlock :eyes:

L-M-Sherlock commented 1 year ago

Could you update the code to pass CI?

GraesonB commented 1 year ago

Oops, my bad. Didn't see the clippy step