search

open-spaced-repetition / srs-benchmark

A benchmark for spaced repetition schedulers/algorithms
https://github.com/open-spaced-repetition/fsrs4anki/wiki
62 stars 9 forks source link

Ensure that data is sorted by 'user'.py #116

Closed Expertium closed 1 month ago

Expertium commented 1 month ago

I'm not 100% sure that your .jsonl output is guaranteed to be in order, so I added this.

L-M-Sherlock commented 1 month ago

The jsonl data is sorted by user id. Which order do you want to sort?

Expertium commented 1 month ago

By user ID. I'm just not sure if it always works. I think when I was running other.py locally, sometimes the order would break. If you think these changes are redundant, close this PR. Also, please read what I said in Discord, in DMs.

L-M-Sherlock commented 1 month ago

I think when I was running other.py locally

I guess you interrupted the benchmark code during training. The sorting is done in the end of benchmarking.