search

open-spaced-repetition / swift-fsrs

Swift Package for FSRS
MIT License
27 stars 14 forks source link

Update codebase to modern Swift style #1

Closed ilyakuteev closed 9 months ago

ilyakuteev commented 9 months ago

For now the codebase uses classes to describe TDO models and uses outdated NSCopying mechanics. The proposal is to use structs instead of classes and to use Equatable instead of NSCopying

bensmiley commented 9 months ago

Feel free to go ahead with these improvements, I'm happy to review the PR.

ilyakuteev commented 9 months ago

https://github.com/open-spaced-repetition/swift-fsrs/pull/2 PR link

ilyakuteev commented 9 months ago

Feel free to go ahead with these improvements, I'm happy to review the PR.

Thanks for quick response. I attached a PR link to the issue.

bensmiley commented 9 months ago

I merged it. Thanks for cleaning up the code.