search

open-spaced-repetition / swift-fsrs

Swift Package for FSRS
MIT License
27 stars 14 forks source link

FSRS Version #10

Closed jfmamjjasond123 closed 5 months ago

jfmamjjasond123 commented 8 months ago

What version of FSRS is used with the swift code?

L-M-Sherlock commented 8 months ago

FSRSv4

jfmamjjasond123 commented 7 months ago

Any plans to update the swift version?

L-M-Sherlock commented 7 months ago

Please ask @bensmiley

tomerbeil commented 5 months ago

@bensmiley Hi!

First of all, thank you for developing the Swift version of FSRS. It’s been incredibly useful! I am curious about the future development plans for this project. Specifically, are there any updates planned to bring FSRS to version 4.5? Looking forward to any information you might have!

Thank you!

aehlke commented 5 months ago

The better approach may be to wrap the rust library into an SPM module instead of duplicating the logic.

https://github.com/chinedufn/swift-bridge

bensmiley commented 5 months ago

@bensmiley Hi!

First of all, thank you for developing the Swift version of FSRS. It’s been incredibly useful! I am curious about the future development plans for this project. Specifically, are there any updates planned to bring FSRS to version 4.5? Looking forward to any information you might have!

Thank you!

HI @tomerbeil I will probably update the code at some point. But given it's a translation from a different language, that can be quite a difficult process because it requires me to identify every place where the code has been modified and then find that place in the Swift code and apply the modification.

The FSRS project is still quite young so my feeling would be to wait until it's more mature and then do the update work. In the meantime maybe the approach suggested by @aehlke would work.

I have limited time so help would be welcome. If you were to submit a pull request with updates I would prioritise merging it.

SplittyDev commented 5 months ago

@bensmiley I've submitted a PR to update everything to FSRS 4.5, and tested using the same parameters as the Go version, achieving the same output.