open-spaced-repetition / swift-fsrs

Swift Package for FSRS
MIT License
27 stars 14 forks source link

Update algorithm to FSRS 4.5 #14

Closed SplittyDev closed 5 months ago

SplittyDev commented 5 months ago

Hey, this PR updates the algorithm to FSRS 4.5.

Changes

Sources

New values for the forgetting curve etc. have been taken from:

Further, the tests have been updates to use the same values (for date and weights) as the Go tests:

This should make it easier to maintain both versions in the future and test them against each other.

Misc

Resolves #10

SplittyDev commented 5 months ago

@ishiko732 I think I've addressed all of your concerns now. Please let me know if the 0 handling for forgettingCurve(...) where stability == 0 is fine.

ishiko732 commented 5 months ago

@L-M-Sherlock @bensmiley cc