upgrade typescript-eslint to version 8

open-spaced-repetition / ts-fsrs

ts-fsrs is a versatile package based on TypeScript that supports ES modules, CommonJS, and UMD.

https://open-spaced-repetition.github.io/ts-fsrs/

MIT License

213 stars 22 forks source link

upgrade typescript-eslint to version 8 #107

Closed joshdavham closed 3 months ago

joshdavham commented 3 months ago

typescript-eslint v8.0.0 was released today which means that projects (like this one) that have both eslint and typescript-eslint no longer have to deal with peer dependency issues between them. I was previously unable to install the dev dependencies in this project, but updating to v8 fixed that.

Let me know if there are any questions / issues 👍

ishiko732 commented 3 months ago

I need to fix the codecov issue before I can merge.😢

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2d6e546) to head (5827853).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #107 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 553 553 Branches 58 58 ========================================= Hits 553 553 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ishiko732 commented 3 months ago

Great, it's finally fixed!

ishiko732 commented 3 months ago

A pnpm-lock.yaml that runs on nodejs 18.20.3 is required, otherwise GitHub Pages cannot be successfully deployed.