open-stage / blender-dmx

Blender addon to design and render DMX lighting.
GNU General Public License v3.0
195 stars 14 forks source link

GDTF import fail - Base, Yoke, Head, Beam geometry naming is required #17

Closed rudolfsbaltins closed 1 year ago

rudolfsbaltins commented 1 year ago

Hi, had an import fail for a GDTF file - https://gdtf-share.com/user-page?name=JB-Lighting&page=fixtures

Python: Traceback (most recent call last): File "C:\Users\r\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\dmx\panels\fixtures.py", line 243, in execute dmx.addFixture(self.name+" "+str(i+1), self.profile, self.universe, self.address, self.mode, self.gel_color) File "C:\Users\r\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\dmx__init__.py", line 501, in addFixture dmx.fixtures[-1].build(name, profile, mode, universe, address, gel_color) File "C:\Users\r\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\dmx\fixture.py", line 149, in build model_collection = DMX_Model.getFixtureModelCollection(gdtf_profile) File "C:\Users\r\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\dmx\model.py", line 35, in getFixtureModelCollection return DMX_GDTF.buildCollection(profile) File "C:\Users\r\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\dmx\gdtf.py", line 217, in buildCollection updateGeom(profile) File "C:\Users\r\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\dmx\gdtf.py", line 215, in updateGeom updateGeom(child_geom, d+1) File "C:\Users\r\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\dmx\gdtf.py", line 179, in updateGeom obj_child = objs[geom.name] KeyError: 'Base'

hugoaboud commented 1 year ago

Hi rudolf,

This problem occurs because the plugin is expecting the fixture to have a "Base" object, which is not a good decision. I have flagged it as a bug and will work on it after we merge some new features and fixes that @vanous is working on.

Thanks for the report

rudolfsbaltins commented 1 year ago

When do you see this coming? I am working on a DMX workflow as I do stage design and it looks like it might be moving in the direction of light design. You don't have any future plans on MVR scene support?

On Wed, 4 Jan 2023 at 03:02, Hugo Aboud @.***> wrote:

Hi rudolf,

This problem occurs because the plugin is expecting the fixture to have a "Base" object, which is not a good decision. I have flagged it as a bug and will work on it after we merge some new features and fixes that @vanous https://github.com/vanous is working on.

Thanks for the report

— Reply to this email directly, view it on GitHub https://github.com/hugoaboud/blenderDMX/issues/17#issuecomment-1370377285, or unsubscribe https://github.com/notifications/unsubscribe-auth/AU2R7WXZIV3XNHZQYPFZEYDWQTDZRANCNFSM6AAAAAATLEAU4E . You are receiving this because you authored the thread.Message ID: @.***>

vanous commented 1 year ago

Fixing the dependency on naming will take some time, but you can work around right now by editing the GDTF file in the GDTF Builder and renaming the base, yoke, head to Base, Yoke, Head.

As for MVR, do you have an example file that you could post here?

Thank you