search

open-sw / pkg-cacher

This is a transparent cache for Debian and RedHat packages (.deb and .rpm). It is based on apt-cacher available on Debian. It has been enhanced to handle RedHat repositories and files whose names are the same but the contents are different.
15 stars 12 forks source link

$filesize is undfined on a 404 #25

Open jkugler opened 10 years ago

jkugler commented 10 years ago

Just a small niggle (noise in the error.log, actually):

Thu Apr 10 15:22:49 2014|warn [5777]: Use of uninitialized value $filesize in concatenation (.) or string at /usr/sbin/pkg-cacher line 236.

When a file is 404, $filesize is apparently uninitialized. Not a huge deal, but just thought I'd mention it.

Robert-Nelson commented 10 years ago

Hmm, I can't reproduce this. Can you tell me the exact repro steps?

----- Original Message -----

| From: "Joshua Kugler" notifications@github.com | To: "open-sw/pkg-cacher" pkg-cacher@noreply.github.com | Sent: Thursday, April 10, 2014 4:18:06 PM | Subject: [pkg-cacher] $filesize is undfined on a 404 (#25)

| Just a small niggle (noise in the error.log, actually): | Thu Apr 10 15:22:49 2014|warn [5777]: Use of uninitialized value $filesize in | concatenation (.) or string at /usr/sbin/pkg-cacher line 236.

| When a file is 404, $filesize is apparently uninitialized. Not a huge deal, | but just thought I'd mention it.

| — | Reply to this email directly or view it on GitHub .

jkugler commented 10 years ago

I did this:

wget http://localhost4:9000/job/e2fsprogs-master/arch=x86_64,distro=el6/lastSuccessfulBuild/artifact/_topdir/RPMS/x86_64/e2fsprogs-1.42.7.wc2-7.el6.x86_64.rpm

That generated a 404, which produced this in the error log:

Thu Apr 10 23:40:56 2014|warn [6429]: Use of uninitialized value $filesize in concatenation (.) or string at /usr/sbin/pkg-cacher line 236.

And this in the access log:

Thu Apr 10 23:40:56 2014|6429|127.0.0.1|MISS||e2fsprogs-1.42.7.wc2-7.el6.x86_64.rpm

(no file size between MISS and the file name)

Robert-Nelson commented 10 years ago

Is this with the actual release? I can't seem to reproduce it.

----- Original Message -----

| From: "Joshua Kugler" notifications@github.com | To: "open-sw/pkg-cacher" pkg-cacher@noreply.github.com | Cc: "Robert Nelson" robertn@the-nelsons.org | Sent: Thursday, April 10, 2014 11:44:25 PM | Subject: Re: [pkg-cacher] $filesize is undfined on a 404 (#25)

| I did this: | wget | http://localhost4:9000/job/e2fsprogs-master/arch=x86_64,distro=el6/lastSuccessfulBuild/artifact/_topdir/RPMS/x86_64/e2fsprogs-1.42.7.wc2-7.el6.x86_64.rpm

| That generated a 404, which produced this in the error log:

| Thu Apr 10 23:40:56 2014|warn [6429]: Use of uninitialized value $filesize in | concatenation (.) or string at /usr/sbin/pkg-cacher line 236.

| And this in the access log:

| Thu Apr 10 23:40:56 | 2014|6429|127.0.0.1|MISS||e2fsprogs-1.42.7.wc2-7.el6.x86_64.rpm

| (no file size between MISS and the file name)

| — | Reply to this email directly or view it on GitHub .

jkugler commented 10 years ago

Yes, this is 1.1.0.

Here is my config. Maybe because it's retrieving over SSL?

cache_dir=/var/www/cobbler/pkg-cacher
admin_email=hpdd-devops@intel.com
daemon_port=9000
group=pkg-cacher
user=pkg-cacher
allowed_hosts=*
denied_hosts=
allowed_hosts_6=fec0::/16
denied_hosts_6=
generate_reports=1
clean_cache=0
offline_mode=0
logdir=/var/log/pkg-cacher
expire_hours=0
use_proxy=0
limit=0
debug=0
require_valid_ssl=0
path_map = job https://build.whamcloud.com/job/

I had a user/pass for the host, but the file I pulled in my above example does not require a user/host to retrieve.

Robert-Nelson commented 10 years ago

No I tried it with https and the exact same paths. Ah just looked at the code and I figured out what is going on. I didn't see it because my main system runs in cgi mode, there requests aren't being logged if status isn't 200 which is another bug. I'll fix both and put back parallel fetch for non https hosts and release ver 1.1.1

----- Original Message -----

| From: "Joshua Kugler" notifications@github.com | To: "open-sw/pkg-cacher" pkg-cacher@noreply.github.com | Cc: "Robert Nelson" robertn@the-nelsons.org | Sent: Friday, April 11, 2014 4:08:33 PM | Subject: Re: [pkg-cacher] $filesize is undfined on a 404 (#25)

| Yes, this is 1.1.0.

| Here is my config. Maybe because it's retrieving over SSL? | cache_dir=/var/www/cobbler/pkg-cacher | admin_email=hpdd-devops@intel.com | daemon_port=9000 | group=pkg-cacher | user=pkg-cacher | allowed_hosts=* | denied_hosts= | allowed_hosts_6=fec0::/16 | denied_hosts_6= | generate_reports=1 | clean_cache=0 | offline_mode=0 | logdir=/var/log/pkg-cacher | expire_hours=0 | use_proxy=0 | limit=0 | debug=0 | require_valid_ssl=0 | path_map = job https://build.whamcloud.com/job/

| I had a user/pass for the host, but the file I pulled in my above example | does not require a user/host to retrieve.

| — | Reply to this email directly or view it on GitHub .