open-switch / opx-cps

https://openswitch.net
6 stars 15 forks source link

base-ip/ipv4/enabled missing from query and does not work #76

Closed james-jra closed 5 years ago

james-jra commented 6 years ago

Setting base-ip/ipv4/enabled does not seem to do anything. I would expect it to act the same as base-ip/ipv6/enabled.

Also it is absent when querying configuration.

Reproduce

============1.22.1441815.1441805.========== base-ip/ipv6/forwarding = 1 base-ip/ipv6/name = e101-002-0 base-ip/ipv6/vrf-id = 0 base-ip/ipv6/autoconf = 1 base-ip/ipv6/enabled = 0 <------------ base-ip/ipv6/ifindex = 14

* Query IPv4 configuration - base-ip/ipv4/enabled is not present

opxUser@opx221_vm:~$ sudo cps_get_oid.py base-ip/ipv4 base-ip/ipv4/name=e101-002-0

============1.22.1441814.1441812.========== base-ip/ipv4/vrf-id = 0 base-ip/ipv4/name = e101-002-0 base-ip/ipv4/forwarding = 1 base-ip/ipv4/address/prefix-length = 24 base-ip/ipv4/address/ip = 0a0b0c02 base-ip/ipv4/address/prefix-length = 24 base-ip/ipv4/address/ip = ac1c800c base-ip/ipv4/ifindex = 14

atanu-mandal commented 6 years ago

Hi @james-jra , it seems this "enabled" attribute is meant for ipv6 only (though I understand it is part of common ip config param group which is bit confusing).

Please refer the description inside the yang model.

https://github.com/open-switch/opx-base-model/blob/dcadb2f62b44fc399b33eed0c0bd721334544569/yang-models/dell-base-ip.yang#L53

Do you have specific requirement to disable ipv4 ?

james-jra commented 6 years ago

Thanks for your feedback We do not have a specific requirement to disable IPv4

If the "enabled" attribute is only relevant for IPv6, do you intend to fix the dell-base-ip YANG model? (remove the "enabled" field from the "common-ip-config-param" group and make it specific to IPv6?)

atanu-mandal commented 6 years ago

Thanks James for your response. We will plan to fix the dell-base-ip YANG model.