search

open-telemetry / .allstar

Enable and house Allstar policies centrally for the organizatio
0 stars 4 forks source link

How to comply with static-check-required rule? #8

Open trask opened 9 months ago

trask commented 9 months ago

I'm not clear what the intention of static-check-required rule is and so not sure how to comply with it.

Related to https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/10427

pellared commented 9 months ago

See https://github.com/open-telemetry/.allstar/pull/3#discussion_r1461483967

CC @sakshi-1505

sakshi-1505 commented 9 months ago

@trask This was to fail intentionally; let me get this fixed.

sakshi-1505 commented 8 months ago

@trask I am in midst of implementing the fix for your repo but I couldn't find any GitHub-action which would do static-check for your code? Can you please point me if there's one or do we need to add them?

trask commented 8 months ago

we use errorprone as part of our build, is that the kind of static checking you are looking for? we also run CodeQL daily

sakshi-1505 commented 8 months ago

we use errorprone as part of our build, is that the kind of static checking you are looking for? we also run CodeQL daily

I think this should do

trask commented 8 months ago

@sakshi-1505 what should we do to resolve this? thanks

EDIT sorry, just saw your PR linked above 👍

trask commented 8 months ago

hi all, this is still pinging us daily in the java instrumentation repo: https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/10427

breedx-splk commented 5 months ago

Last ping was March 1st, so maybe we're good to close this now?