Open trask opened 1 year ago
pinging all maintainers for repos that are using OPENTELEMETRYBOT_GITHUB_TOKEN
so far, the fine-grained token has only the permissions in the screenshot below.
this has been enough for the Java repos, but we aren't using @opentelemetrybot to update issues, so if you have any automation that requires updating issue (or anything else besides creating/updating PRs) let me know
@trask thanks for letting us know.
In the operator repo we use the bot to sync some 3rd party GH repos and open PRs (similar to what is done in the java auto-instrumentation to submit PRs to the operator repo). Will that continue to work?
After looking at the use of this token in the collector & collector-contrib repos, i believe the workflows will continue to work for those repos with the fine grained PAT.
@pavolloffay I think you will need more access for that usage.
I've created a separate fine-grained PAT that I think will give you the access you need to opentelemetrybot's forks (see screenshot below).
@open-telemetry/technical-committee what do you think about storing this new fine-grained PAT in an org secret scoped to only opentelemetry-operator
repository, named OPENTELEMETRYBOT_OPERATOR_FORKS_GITHUB_TOKEN
.
@open-telemetry/technical-committee what do you think about storing this new fine-grained PAT in an org secret scoped to only
opentelemetry-operator
repository, namedOPENTELEMETRYBOT_OPERATOR_FORKS_GITHUB_TOKEN
.
@arminru what do you think?
@open-telemetry/technical-committee what do you think about storing this new fine-grained PAT in an org secret scoped to only
opentelemetry-operator
repository, namedOPENTELEMETRYBOT_OPERATOR_FORKS_GITHUB_TOKEN
.@arminru what do you think?
@trask +1 on using the fine-grained tokens scoped to individual repos instead of the org-wide OTel Bot token. I'll reach out to you directly to set it up.
@arminru and I discussed on slack and agreed for now at least that we would share repo-specific tokens directly with maintainers of those repos instead of adding them as repo-scoped org secrets
@pavolloffay I'll send you a one-time link for the PAT that can be used for the above operator workflows
@trask In OTel Python we only use OPENTELMETRYBOT_GITHUB_TOKEN
for our release process (you commited the .yml
files yourself). We made a change to use OPENTELMETRYBOT_GITHUB_TOKEN
afterwards.
In Pyhton we only use this token in our release process to create release PRs. We should be ok :+1:
See motivation at https://github.com/open-telemetry/community/issues/1503#issuecomment-1562214077.
I will be pinging the repos which are already using the org secret to let them know we'll be switching the org secret over to a fine-grained PAT.
Current target is to make this switch on Wed, June 28 (I'm on vacation next week so want to wait until afterwards in case any issues).
After we switch the org secret over to the fine-grained PAT, I'll revoke the old PAT.