open-telemetry / community

OpenTelemetry community content
https://opentelemetry.io
Apache License 2.0
754 stars 229 forks source link

New teams `docs-ja-approvers` and `docs-ja-maintainers` #2138

Closed svrnm closed 3 months ago

svrnm commented 3 months ago

Affected Repository

https://github.com/open-telemetry/opentelemetry.io https://github.com/open-telemetry/docs-ja

Requested changes

This request is similar to #2107

Purpose

We now have our second translation at https://opentelemetry.io/ja :tada:

@ymotongpoo, @katzchang are our first approver in this group. Eventually we also want to add @shirou but they need to become member of the Org first. We will work on that separately.

We will also work on checking what to do with https://github.com/open-telemetry/docs-ja, so please also make the newly formed group maintainers/admins for that repository.

Expected Duration

permanently

Repository Maintainers

@open-telemetry/docs-maintainers

ymotongpoo commented 3 months ago

Thank you @svrnm for the update and logistics!

chalin commented 3 months ago

Thanks @svrnm.

  • [ ] Create a new group docs-ja-approvers with @ymotongpoo as member, and @cartermp, @austinlparker, @chalin and @svrnm as members (all as "maintainers" for the group)
  • [ ] Create a new sub-group to docs-ja-approvers named docs-ja-maintainers with @cartermp, @austinlparker, @chalin and @svrnm as members (all as "maintainers" for the group)

Hmm, I'd suggest we keep things DRY: that is, keeping the membership exclusive. Concretely:

The zh groups should be similarly adjusted.

We then use CODEOWNERS to achieve the effect of what was originally requested, as was done via https://github.com/open-telemetry/opentelemetry.io/pull/4584.

@svrnm et @open-telemetry/docs-maintainers WDYT?

svrnm commented 3 months ago

@chalin having the docs-maintainers in those groups allows us to add people without raising a community issue everytime, we can remove ourselves eventually when things have evolved.

chalin commented 3 months ago

Thanks for providing a rational. Ok, then instead we should add @open-telemetry/docs-maintainers as a subgroup of docs-ja-maintainers.

arminru commented 3 months ago

@chalin Unfortunately that's not possible because each team can only one parent and @open-telemetry/docs-maintainers is already a child of @open-telemetry/docs-approvers as per https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md#collaborators-and-teams.

arminru commented 3 months ago

Created @open-telemetry/docs-ja-maintainers (with Maintain permissions on https://github.com/open-telemetry/docs-ja) and @open-telemetry/docs-ja-approvers (with Write permissions on https://github.com/open-telemetry/docs-ja) as per https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md#collaborators-and-teams.

arminru commented 3 months ago

@shirou once you're a member of the https://github.com/open-telemetry org, any @open-telemetry/docs-ja-maintainers can invite you to @open-telemetry/docs-ja-approvers.

svrnm commented 3 months ago

Thanks @arminru